Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(android): add additional okhttp dependency #1452

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

ferdicus
Copy link
Member

@ferdicus ferdicus commented Jul 9, 2021

Description

This adds an additional okhttp dependency okhttp-urlconnection, that will prevent
java.lang.NoSuchMethodError: No virtual method toString(Z)Ljava/lang/String; in class Lokhttp3/Cookie errors

mentioned:
here
here

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I mentioned this change in CHANGELOG.md
    * [ ] I updated the documentation yarn generate
    * [ ] I updated the typings files (index.d.ts)
    * [ ] I added/ updated a sample (/example)

@ferdicus ferdicus self-assigned this Jul 9, 2021
@ferdicus ferdicus force-pushed the build/android-okhttp-fix branch from 5e880be to 50800ee Compare July 9, 2021 12:51
@ferdicus
Copy link
Member Author

ferdicus commented Jul 9, 2021

@zholmes1, @1337LutZ,
would you be so kind to try this out and make sure, that your usecase is still working with this one :)

Much obliged 🙇🏿

@1337LutZ
Copy link

1337LutZ commented Jul 9, 2021

Just tested it on your branch and it didn't crash. (I removed my manually added package httpOk reference)

@ferdicus
Copy link
Member Author

ferdicus commented Jul 9, 2021

Just tested it on your branch and it didn't crash. (I removed my manually added package httpOk reference)

Thanks a bunch

@ferdicus ferdicus merged commit b73056f into master Jul 16, 2021
@ferdicus ferdicus deleted the build/android-okhttp-fix branch July 16, 2021 09:02
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants