test: add unit tests for component light #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inline styles in GradienLine led to a linter error which prevents from commiting via cli.
mikalaiulasevich
pushed a commit
to OneSoil-Platform/maps
that referenced
this pull request
Sep 23, 2021
* fix: apply to lint rule no-inline-styles The inline styles in GradienLine led to a linter error which prevents from commiting via cli. * test: add unit tests for Light component * chore: update CHANGELOG * fix: add missing closing brackets in CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit tests for the small component
Light.jsis a first step to contribute to missing component tests.Please note:
When I tried to commit via the command line, the
pre-commitlinting step threw an error onLineGradientbecause of inline styles. I fixed that by extracting the styles.Please let me know if it would have been more appropriate to disabled the linting rule.
Checklist
yarn generateCHANGELOG.mdindex.d.ts)/example)Screenshot OR Video
none