Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin] fix: exclude arm64 architectures for simulator builds #1490

Merged
merged 3 commits into from
Aug 20, 2021
Merged

[plugin] fix: exclude arm64 architectures for simulator builds #1490

merged 3 commits into from
Aug 20, 2021

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Aug 10, 2021 •
edited
Loading

Description

Release builds for simulators are failing because they target arm64, this change disables arm64 for simulator builds (related maplibre/maplibre-native#4)

Repro

  • expo init
  • expo add @react-native-mapbox-gl/maps
  • Add @react-native-mapbox-gl/maps to plugins
  • expo run:ios --configuration Release (targets a simulator by default)
    This will fail with:
❌  ld: building for iOS Simulator, but linking in dylib built for iOS, file '/path/to/app/ios/Pods/Mapbox-iOS-SDK/dynamic/Mapbox.framework/Mapbox' for architecture arm64

Adding the new plugin and rerunning expo prebuild -p ios --no-install will sync changes, rerunning expo run:ios --configuration Release will work as expected.

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

Screenshot OR Video

@EvanBacon EvanBacon mentioned this pull request Aug 10, 2021
Merged
3 tasks
ferdicus
ferdicus approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@ferdicus ferdicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @EvanBacon

@ferdicus ferdicus merged commit 7ab300d into rnmapbox:master Aug 20, 2021
@EvanBacon EvanBacon deleted the @evanbacon/plugin/added-excluded-ios-architectures branch August 24, 2021 05:14
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
@EvanBacon @ferdicus @mikalaiulasevich
[plugin] fix: exclude arm64 architectures for simulator builds (rnmap…
ccc1f4e 
…box#1490)

* fix: exclude arm64 architectures for simulator builds

* Update CHANGELOG.md

Co-authored-by: Kid Commit <26439946+ferdicus@users.noreply.github.com>
@mfazekas mfazekas mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferdicus ferdicus ferdicus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanBacon @ferdicus