Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds getClusterChildren for iOS and Android #1495

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Adds getClusterChildren for iOS and Android #1495

merged 1 commit into from
Aug 20, 2021

Conversation

tr3v3r
Copy link
Contributor

@tr3v3r tr3v3r commented Aug 16, 2021 •
edited by ferdicus
Loading

Description

Adds getClusterChildren method to ShapeSource that allows you to retrieve the features from a cluster by the cluster's ID. (on the next zoom level)

Features may include nested clusters as well.

shapeSourceRef.current.getClusterChildren(clusterId);

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

Screenshot OR Video

@tr3v3r
Copy link
Contributor Author

tr3v3r commented Aug 17, 2021 •
edited
Loading

@ferdicus Hello! Could someone take a look, please?

mfazekas
mfazekas approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@mfazekas mfazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tr3v3r
Copy link
Contributor Author

tr3v3r commented Aug 18, 2021

@mfazekas Hello! Are you planning to release the next ver of the library in the short term? We really need this functionality.
So maybe something that I can help with to speed up the process?

Thank you in advance )

@ferdicus
Copy link
Member

@mfazekas Hello! Are you planning to release the next ver of the library in the short term? We really need this functionality.
So maybe something that I can help with to speed up the process?

Thank you in advance )

Will be releasing a new version on friday

ferdicus
ferdicus approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@ferdicus ferdicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

@ferdicus ferdicus merged commit 260852b into rnmapbox:master Aug 20, 2021
ferdicus
ferdicus reviewed Aug 20, 2021
View reviewed changes
ios/RCTMGL/RCTMGLShapeSourceManager.m
[self.bridge.uiManager addUIBlock:^(__unused RCTUIManager *manager, NSDictionary<NSNumber*, UIView*> *viewRegistry) {
RCTMGLShapeSource* shapeSource = (RCTMGLShapeSource *)viewRegistry[reactTag];

NSArray<id<MGLFeature>> *shapes = [sтвhapeSource getClusterChildren: clusterId];
Copy link
Member

@ferdicus ferdicus Aug 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typo snuck in there 😅

@ferdicus
Copy link
Member

@mfazekas Hello! Are you planning to release the next ver of the library in the short term? We really need this functionality.
So maybe something that I can help with to speed up the process?

Thank you in advance )

https://github.com/react-native-mapbox-gl/maps/releases/tag/8.3.0

mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
@tr3v3r @mikalaiulasevich
Adds getClusterChildren for iOS and Android (rnmapbox#1495)
cc7c404
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
@tr3v3r @mikalaiulasevich
Adds getClusterChildren for iOS and Android (rnmapbox#1495)
f5a6b36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferdicus ferdicus ferdicus approved these changes

@mfazekas mfazekas mfazekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tr3v3r @ferdicus @mfazekas