style(eslint): align root and example with the same configuration

[lisabaut]

Description

Hi there 👋

As mentioned in this PR here https://github.com/react-native-mapbox-gl/maps/pull/1486 I said I would look into the linting issue (running yarn lint from root-level causes error in example folder).

I ended up with a refactoring of the current eslint and tslint set-up which now ensures that one configuration works in all JS and TS files.

This PR does:

• fix the linting script error mentioned above
• remove all eslint and tslint packages from example to root
• align the one eslintrc configuration with the same rules as before for JS from the root folder
• align the one eslintrc configuration with the same rules as before for TS/X files from example folder
• change script yarn lint to lint all files in all folders with one configuration
• lint all files in all folder with the same rules
• fix all errors
• fix some warnings

Checklist

• I have tested this on a device/simulator for each compatible OS
• I updated the documentation yarn generate
• I mentioned this change in CHANGELOG.md
• I updated the typings files (index.d.ts)
• I added/ updated a sample (/example)

Questions:

• Let me know if you are missing some JS rules from the deleted eslintrc file of the example folder :) I decided to take all JS rules from eslintrc of the root folder
• I needed to update cocoapods in order to make the iOS simulator run, after that the file project.pbxproj was changed, please see the commit here. I assume, I need to revert this commit?
• after running yarn generate the file for OfflineManager.md was changed, is this correct?
• does this repo use yarn or npm ?
• I assume the script yarn format and yarn lint are doing the same now with this PR and one can be removed?

[ferdicus]

hey @lisabaut, pretty cool - thanks for taking care of this 👍🏿

Some notes:
When I run this in root, I still get two errors 🤔

• javascript/utils/animated/AnimatedRouteCoordinatesArray.js
4:3 error convertDistance not found in '@turf/helpers' import/named
• example/src/examples/Annotations/CustomCallout.tsx
3:9 error Feature not found in '@turf/helpers' import/named

Let me know if you are missing some JS rules from the deleted eslintrc file of the example folder :) I decided to take all JS rules from eslintrc of the root folder

Nah, all good 👍🏿 We can extend when we find something missing later on

I needed to update cocoapods in order to make the iOS simulator run, after that the file project.pbxproj was changed, please see the commit here. I assume, I need to revert this commit?

Yes, please revert - that's taken care off by the upgrade to RN 0.66 PR (#1570 )

after running yarn generate the file for OfflineManager.md was changed, is this correct?

That was probably forgotten during another PR - you can also revert that, as it's taken care off by #1577

does this repo use yarn or npm ?

We're trying to be npm/yarn indifferent - however there are some instances, like within package.json where npm is used to reference scripts within scripts. If you find occurrences like that and can change them to run without referencing npm or yarn specifically feel free to change them 👍🏿

I assume the script yarn format and yarn lint are doing the same now with this PR and one can be removed?

Correct, feel free to remove one.

Running yarn lint just from the example folder would be nice - but maybe for a follow up PR 🙇🏿

Again, thank you very much for your contribution 🙇🏿

Cheers 🍻

[lisabaut]

Some notes: When I run this in root, I still get two errors 🤔

* `javascript/utils/animated/AnimatedRouteCoordinatesArray.js`
  `4:3  error  convertDistance not found in '@turf/helpers'  import/named`

* `example/src/examples/Annotations/CustomCallout.tsx`
  `3:9   error    Feature not found in '@turf/helpers'      import/named`

That is weird. I am not able to reproduce these errors.
I ran yarn purge in the example folder again and deleted the node modules from the root folder.
Then yarn and yarn lint in the root folder => no errors (but the expected 105 warnings)
Then cd into example folder and yarn and cd .. && yarn lint again => same result

Any idea what I am missing here?
Thanks.

[ferdicus]

Some notes: When I run this in root, I still get two errors 🤔

* `javascript/utils/animated/AnimatedRouteCoordinatesArray.js`
  `4:3  error  convertDistance not found in '@turf/helpers'  import/named`

* `example/src/examples/Annotations/CustomCallout.tsx`
  `3:9   error    Feature not found in '@turf/helpers'      import/named`

That is weird. I am not able to reproduce these errors. I ran yarn purge in the example folder again and deleted the node modules from the root folder. Then yarn and yarn lint in the root folder => no errors (but the expected 105 warnings) Then cd into example folder and yarn and cd .. && yarn lint again => same result

Any idea what I am missing here? Thanks.

hmm 🤔, weird, yeah I'm doing the same thing....

only additional step I ran was rm -rf node_modules in root as yarn purge only takes care of /example

let's merge this - it's already better than it previously was :)

Maybe, if you find the time: We do not have a linting workflow - maybe you'd like to add one in the future?

Cheers 🍻

[lio-ioki]

Maybe, if you find the time: We do not have a linting workflow - maybe you'd like to add one in the future?

Sure, with running the tests as well I suppose, as I could not find a workflow for this script either.

[ferdicus]

Maybe, if you find the time: We do not have a linting workflow - maybe you'd like to add one in the future?

Sure, with running the tests as well I suppose, as I could not find a workflow for this script either.

That's included in the android workflow, see:
https://github.com/react-native-mapbox-gl/maps/blob/0d7435c76bbc5e9099cc8a3d5380f9f0065fcca6/.github/workflows/android-actions.yml#L17

Not saying those can't be improved though.
Building could be decoupled from testing for example.

Thanks again 🙇🏿

[veb-ioki]

Some notes: When I run this in root, I still get two errors 🤔

* `javascript/utils/animated/AnimatedRouteCoordinatesArray.js`
  `4:3  error  convertDistance not found in '@turf/helpers'  import/named`

* `example/src/examples/Annotations/CustomCallout.tsx`
  `3:9   error    Feature not found in '@turf/helpers'      import/named`

That is weird. I am not able to reproduce these errors. I ran yarn purge in the example folder again and deleted the node modules from the root folder. Then yarn and yarn lint in the root folder => no errors (but the expected 105 warnings) Then cd into example folder and yarn and cd .. && yarn lint again => same result
Any idea what I am missing here? Thanks.

hmm 🤔, weird, yeah I'm doing the same thing....

only additional step I ran was rm -rf node_modules in root as yarn purge only takes care of /example

let's merge this - it's already better than it previously was :)

Maybe, if you find the time: We do not have a linting workflow - maybe you'd like to add one in the future?

Cheers 🍻

Just FYI, now that the PR is merged, I pulled and tested on my machine:
root => yarn purge, yarn, yarn lint => no errors, only loads of warnings
cd example => yarn purge, yarn => cd to root again & yarn lint => no errors, only loads of warnings