-
-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(android): camera bounds, zoom, and animation mode handling #3375
Conversation
android/src/main/java/com/rnmapbox/rnmbx/components/camera/RNMBXCamera.kt
Outdated
Show resolved
Hide resolved
I could not repro the issue in a new expo project, yes you'll need to run eas build again after @rnmapbox/maps update. Pls open a discussion, if it doesn't fix as it's not related to this PR |
@mfazekas Updated the description at the top and simplified changes - let me know what you think. |
android/src/main/java/com/rnmapbox/rnmbx/components/camera/RNMBXCamera.kt
Outdated
Show resolved
Hide resolved
@mfazekas Weird, it seems like my edit to the description didn't save properly before, but it was still cached locally. I just resubmitted it. |
I see thank you! Creating a new project and installing all dependencies fixed the issue. |
This is a refactor to fix bounds and zoom handling on Android, similar to #3354 on iOS.
There wasn't a double-padding issue like on iOS, but Android did have these problems:
See before and after (using example at this commit):
Before:
old.mov
After:
new.mov