Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corepack compatibility for v1 yarn...yarn@1 still is super slow #3607

Conversation

FrederickEngelhardt
Copy link
Contributor

Description

  • Fixes yarn install issues with corepack.
  • Allows for corepack to point to the yarn v1 dependency
  • Adds the whole cjs file for yarn with the command yarn set version 1.22.22

Corepack then updates to the correct yarn version by running corepack use yarn@1.22.22.

Added your feature that allows ...

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Component to reproduce the issue you're fixing

@mfazekas
Copy link
Contributor

mfazekas commented Sep 3, 2024

@FrederickEngelhardt thanks but I'd rather not add yarn cjs to the repo.

Fixes yarn install issues with corepack.
Please document the issue you're seeing.

The yarn v4 PR, looks better for me, so closing this.

@mfazekas mfazekas closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants