-
-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): enable setSourceVisibility for Mapbox 11 #3616
feat(ios): enable setSourceVisibility for Mapbox 11 #3616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bvanderdrift thanks looks nice!
@mfazekas some of the checks were failing in the Mapbox 10 compile case. I've fixed them and confirmed locally this case now also works. Curious to see if the CI agrees with me. |
Happy to see all have passed. I don't seem to be able to merge. @mfazekas would you do the honors? |
@bvanderdrift thanks much! |
Description
Fixes #3614
The reason this function stopped working in Mapbox 11 seems because of the change noted here. This is my first attempt at fixing it. We are already using the fix in our project.
I'm on some hard deadlines, so need some external help with:
Also snuck in a typo fix in the docs, hopefully that's okay!
Checklist
CONTRIBUTING.md
yarn generate
in the root folder/example
app./example
)Screenshot OR Video
Please compare with the video in #3614
Screen.Recording.2024-09-05.at.17.mp4
Component to reproduce the issue you're fixing
See the component in #3614