Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): enable setSourceVisibility for Mapbox 11 #3616

Merged

Conversation

bvanderdrift
Copy link
Contributor

@bvanderdrift bvanderdrift commented Sep 5, 2024

Description

Fixes #3614

The reason this function stopped working in Mapbox 11 seems because of the change noted here. This is my first attempt at fixing it. We are already using the fix in our project.

I'm on some hard deadlines, so need some external help with:

  • Making this code more proper (I'm not a Swift developer, I'm sure there's lots I can improve here)
  • Testing w/ the example app.

Also snuck in a typo fix in the docs, hopefully that's okay!

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Please compare with the video in #3614

Screen.Recording.2024-09-05.at.17.mp4

Component to reproduce the issue you're fixing

See the component in #3614

Copy link
Contributor

@mfazekas mfazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvanderdrift thanks looks nice!

@bvanderdrift
Copy link
Contributor Author

@mfazekas some of the checks were failing in the Mapbox 10 compile case. I've fixed them and confirmed locally this case now also works. Curious to see if the CI agrees with me.

@bvanderdrift
Copy link
Contributor Author

Happy to see all have passed. I don't seem to be able to merge. @mfazekas would you do the honors?

@mfazekas mfazekas merged commit 96552bc into rnmapbox:main Sep 19, 2024
11 checks passed
@mfazekas
Copy link
Contributor

@bvanderdrift thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: setSourceVisibility not working
2 participants