-
-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add preferredFramesPerSecond support #3627
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@knowbody thanks looks nice, I think we need to add them to MapViewSpec so it works with new arch as well
would you be able to help me or point me in the right direction on how/where to do it? |
Sure. First you have to add to: maps/src/specs/RNMBXMapViewNativeComponent.ts Lines 35 to 37 in 96552bc
Then run yarn generate to update java interfaces for old arch. compassFadeWhenNorth:
And add where it is. |
@knowbody what's the status on this? Do you need help to move it forward? |
@mfazekas I do apologise, now I have notifications on so will be more responsive. I updated my PR. When I tried running
otherwise I did the changes you asked for |
Description
Added support for
preferredFramesPerSecond
property in both iOS and Android, which allows developers to set the preferred frame rate for rendering the MapView. This feature is especially useful for optimizing performance and battery usage by adjusting the frame rate dynamically.Checklist
CONTRIBUTING.md
yarn generate
in the root folder/example
app./example
)Screenshot OR Video
N/A
Component to reproduce the issue you're fixing