Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install_gpg_all.sh is broken, and installs only the latest version #13

Closed
skalee opened this issue Nov 6, 2018 · 1 comment
Closed

install_gpg_all.sh is broken, and installs only the latest version #13

skalee opened this issue Nov 6, 2018 · 1 comment

Comments

@skalee
Copy link
Contributor

skalee commented Nov 6, 2018 •
edited
Loading

  1. The usage of install_gpg_all.sh appears bogus since it's supposed to be of the syntax ./install_gpg_all.sh -i 2.2, rather than ./install_gpg_all.sh 2.2. It is silently changed to "latest" in all usages in these tests. But if you actually use it correctly, you'll get an error since GPG_VERSION is a readonly and is later reassigned.

Originally posted by @dewyatt in #12 (comment)

Also, both README and script comments inform about outdated synopsis.
@skalee skalee changed the title README is totally incorrect on install_gpg_all.sh, so does in-script comments install_gpg_all.sh is broken, and installs only the latest version Nov 6, 2018
@skalee skalee mentioned this issue Nov 6, 2018
Merged
@skalee
Copy link
Contributor Author

skalee commented Nov 19, 2018

It has been fixed in #17, #22, and #24.

@skalee skalee closed this as completed Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skalee