Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GnuPG installation from Git #24

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Fix GnuPG installation from Git #24

merged 2 commits into from
Nov 19, 2018

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Nov 16, 2018 •
edited
Loading

Install required development packages in Travis, and fix documentation building.

@skalee skalee force-pushed the install-from-git branch 8 times, most recently from 20271c4 to b2c5375 Compare November 17, 2018 05:18
@skalee
Fix GnuPG installation from Git sources
1a52eca 
Tarball releases include some prebuild architecture-agnostic files.
If the source code is fetched from Git repository, then
an --enable-maintainer-mode option must be passed to configure script
in order to produce these files.
@skalee
Improve example which covers installing from Git
8d34d12 
Install required dependencies, and set some configure script options
in order to make build passing.  Also, fix assertions to match
the development GnuPG version correctly.
@skalee skalee requested a review from dewyatt November 19, 2018 08:19
@skalee
Copy link
Contributor Author

skalee commented Nov 19, 2018 •
edited
Loading

I guess it's ready now, review from @dewyatt is welcome. README is yet to be updated, but I'll prepare a larger set of improvements in another pull request.

FYI, building from Git source in CentOS is more difficult than in Ubuntu. CentOS features some outdated version of Automake (minimum 1.14 is required whereas CentOS package repositories have only 1.13, therefore it must be built from source).

@dewyatt
Copy link
Contributor

dewyatt commented Nov 19, 2018

FYI, building from Git source in CentOS is more difficult than in Ubuntu. CentOS features some outdated version of Automake (minimum 1.14 is required whereas CentOS package repositories have only 1.13, therefore it must be built from source).

I noticed this too, I have a ribose-autoamke116 SCL package that I made locally for this that I've been meaning to publish.

dewyatt
dewyatt approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@dewyatt dewyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronaldtse ronaldtse self-requested a review November 19, 2018 12:49
ronaldtse
ronaldtse approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ni4 !

@ronaldtse ronaldtse merged commit bbb47b5 into master Nov 19, 2018
@ronaldtse ronaldtse deleted the install-from-git branch November 19, 2018 12:49
This was referenced Nov 19, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse approved these changes

@dewyatt dewyatt dewyatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skalee @dewyatt @ronaldtse