fix: rename integration tests so they actually get run

roach-php · Mar 27, 2023 · cce5cf5 · cce5cf5
1 parent 96c9332
commit cce5cf5
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 266 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -51,5 +51,8 @@ jobs:
       - name: Start server
         run: (php -S localhost:8000 -t ./tests/Server &) || /bin/true
 
+      - name: Wait for server bootup
+        run: sleep 3
+
       - name: Execute tests
         run: vendor/bin/phpunit
diff --git a/...e/ExecuteJavascriptMiddlewareTestCase.php → ...eware/ExecuteJavascriptMiddlewareTest.php b/...e/ExecuteJavascriptMiddlewareTestCase.php → ...eware/ExecuteJavascriptMiddlewareTest.php
@@ -23,7 +23,7 @@
 /**
  * @internal
  */
-final class ExecuteJavascriptMiddlewareTestCase extends IntegrationTestCase
+final class ExecuteJavascriptMiddlewareTest extends IntegrationTestCase
 {
     use InteractsWithRequestsAndResponses;
 

diff --git a/...iddleware/RobotsTxtMiddlewareTestCase.php → ...er/Middleware/RobotsTxtMiddlewareTest.php b/...iddleware/RobotsTxtMiddlewareTestCase.php → ...er/Middleware/RobotsTxtMiddlewareTest.php
@@ -33,7 +33,7 @@
 /**
  * @internal
  */
-final class RobotsTxtMiddlewareTestCase extends IntegrationTestCase
+final class RobotsTxtMiddlewareTest extends IntegrationTestCase
 {
     use InteractsWithRequestsAndResponses;
 

diff --git a/tests/EngineTestCase.php b/tests/EngineTestCase.php
diff --git a/tests/IntegrationTestCase.php b/tests/IntegrationTestCase.php
@@ -29,16 +29,14 @@ protected function setUp(): void
         $this->skipIfServerNotRunning();
 
         try {
-            \unlink(__DIR__ . '/Server/tmp/crawled.json');
+            @\unlink(__DIR__ . '/Server/tmp/crawled.json');
         } catch (Throwable) {
         }
     }
 
     protected function skipIfServerNotRunning(): void
     {
-        try {
-            \file_get_contents("{$this->serverUrl}/ping");
-        } catch (Throwable) {
+        if (false === @\file_get_contents("{$this->serverUrl}/ping")) {
             self::markTestSkipped('Skipping integration test. Server not running.');
         }
     }