Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RPC::fromEnvironment and RPC::fromGlobals #14

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

roxblnfk
Copy link
Member

No description provided.

@roxblnfk roxblnfk added the enhancement New feature or request label Mar 21, 2023
@roxblnfk roxblnfk requested a review from butschster March 21, 2023 10:36
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.62 ⚠️

Comparison is base (430c884) 73.40% compared to head (a0bf232) 72.78%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #14      +/-   ##
============================================
- Coverage     73.40%   72.78%   -0.62%     
  Complexity      119      119              
============================================
  Files             9        9              
  Lines           297      305       +8     
============================================
+ Hits            218      222       +4     
- Misses           79       83       +4     
Flag Coverage Δ
php 72.78% <ø> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/RPC/RPC.php 72.50% <ø> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@butschster butschster merged commit 54cc3cb into master Mar 21, 2023
@butschster butschster self-assigned this Mar 21, 2023
@butschster butschster deleted the enhancement/deprecations branch April 12, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants