feature: support running inside swoole coroutines

[shellphy]

Q	A
Bugfix?	❌
Breaks BC?	❌
New feature?	compatible swoole coroutine
Issues	closes: 1951
Docs PR	spiral/docs#...

Associate a static seq variable with a link handle instead of an RPC static variable

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[roxblnfk]

Looks ok.
Could you add a test with concurrent requests?

[rustatian]

@shellphy Thank you for the PR 👍
Could you please add docs with a simple example of using as well to the github.com/roadrunner-server/docs repository?

[shellphy]

I added swoole's test case, but there are two problems that can't be tested.

One is the exception problem, because swoole's exception handling is a little different from phpunit's, so I don't know how to test it.

The other is the test of long raw body. The socket message length seems to be limited in the swoole environment.

However, this does not affect the use of most cases.

[rustatian]

@shellphy All CI tests are red 😉 Needs to be green 🟢

[roxblnfk]

Could you please add docs with a simple example of using as well to the github.com/roadrunner-server/docs repository?

The change itself does not require documentation. Do you mean an example of usage with Swoole?

[rustatian]

Could you please add docs with a simple example of using as well to the github.com/roadrunner-server/docs repository?

The change itself does not require documentation. Do you mean an example of usage with Swoole?

docs with a simple example of using

[shellphy]

Could you please add docs with a simple example of using as well to the github.com/roadrunner-server/docs repository?

The change itself does not require documentation. Do you mean an example of usage with Swoole?

The CI environment lacks the swoole extension:

Error: Class 'Swoole\Coroutine' not found

[shellphy]

Could you please add docs with a simple example of using as well to the github.com/roadrunner-server/docs repository?

The change itself does not require documentation. Do you mean an example of usage with Swoole?

docs with a simple example of using

Could you please add docs with a simple example of using as well to the github.com/roadrunner-server/docs repository?

The change itself does not require documentation. Do you mean an example of usage with Swoole?

docs with a simple example of using

roadrunner itself does not rely on swoole, and this patch I made is only compatible with swoole's coroutine environment in rpc project. I think this is not the core function of this project, and few people use swoole and roadrunner at the same time, so I don't think it is necessary to write a special document

[rustatian]

@shellphy

roadrunner itself does not rely on swoole, and this patch I made is only compatible with swoole's coroutine environment in rpc project.

Certainly. You may create a separate pipeline or job and include Swoole extension in it and run the particular tests (concurrent, if you want) in it.
Or, and this is up to you, add concurrent tests (since your core fix is about that) and remove Swoole coroutines test and "ext-swoole": "Swoole gocoroutine support", from your PR.

If you decide to leave Swoole, I would appreciate it if you add a simple example of using it with some brief explanation and links on how to install this extension.
If you decide to remove it, docs are not needed for sure, but you need to test concurrent requests via CI.

[rustatian]

@shellphy we discussed internally, sorry for the confusion, I appreciate what you have done. Since I am not a PHP dev, I thought that Swoole is required to properly test this functionality. Since it is not required, could you please remove this dependency from the suggest block, CI and write a regular PHP tests?

[shellphy]

@shellphy we discussed internally, sorry for the confusion, I appreciate what you have done. Since I am not a PHP dev, I thought that Swoole is required to properly test this functionality. Since it is not required, could you please remove this dependency from the suggest block, CI and write a regular PHP tests?

OK

[msmakouz]

@shellphy Thanks!