Add ability to send separated stream frames #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
roxblnfk
commented
Oct 3, 2023
roxblnfk
commented
| Q | A |
|---|---|
| Bugfix? | ❌ |
| Breaks BC? | ❌ |
| New feature? | ✔️ |
| Issues | roadrunner-php/issues#15 |
- Waiting for Implement Ping-Pong strategy for worker with blocking relay worker#30
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 3.x #18 +/- ##
============================================
+ Coverage 14.63% 18.85% +4.22%
- Complexity 53 60 +7
============================================
Files 4 4
Lines 164 175 +11
============================================
+ Hits 24 33 +9
- Misses 140 142 +2
☔ View full report in Codecov by Sentry. |
… send stop flag if RR has stopped the stream; add comments
roxblnfk
force-pushed
the
stream-worker
branch
from
e448fc4 to
8f31c6a
Compare
butschster
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.