-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RR_VERSION env to Environment class #37
Changes from 5 commits
a876695
2438034
39bfd07
c07921d
c81a6bb
b6170f8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
| Q | A | ||
| ------------- | --- | ||
| Bugfix? | ✔️/❌ | ||
| Breaks BC? | ✔️/❌ <!-- please update "xxx Impact Changes" section in CHANGELOG.md file --> | ||
| New feature? | ✔️/❌ <!-- please update "Other Features" section in CHANGELOG.md file --> | ||
| Issues | #... <!-- prefix each issue number with "#" symbol, no need to create an issue if none exist, explain below instead --> | ||
| Docs PR | spiral/docs#... <!-- prefix each issue number with "spiral/docs#", required only for new features --> | ||
| Q | A | | ||
|--------------|-------------------------------------------------------------------------------------------------------------------------| | ||
| Bugfix? | ✔️/❌ | | ||
| Breaks BC? | ✔️/❌ <!-- please update "xxx Impact Changes" section in CHANGELOG.md file --> | | ||
| New feature? | ✔️/❌ <!-- please update "Other Features" section in CHANGELOG.md file --> | | ||
| Issues | #... <!-- prefix each issue number with "#" symbol, no need to create an issue if none exist, explain below instead --> | | ||
| Docs PR | spiral/docs#... <!-- prefix each issue number with "spiral/docs#", required only for new features --> | | ||
|
||
<!-- Please, replace this notice by a short description of your feature/bugfix. | ||
This will help people understand your PR and can be used as a start for the documentation. --> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,4 +32,9 @@ public function getRelayAddress(): string; | |
* RPC address. | ||
*/ | ||
public function getRPCAddress(): string; | ||
|
||
/** | ||
* Roadrunner version | ||
*/ | ||
public function getVersion(): string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Kaspiman Adding a new method to the interface can break the user implementation of this interface. I suggest not adding the method to the interface, but only to the implementation, and indicating it in the interface as a comment: /**
* Provides base values to configure roadrunner worker.
*
* @psalm-import-type ModeType from Mode
* @see Mode
* @method string getVersion()
*/ The method can then be added in the next major release of the package. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding the missing articles to enhance grammatical correctness.
Committable suggestion
Tools
LanguageTool