Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: weighted serve calls #135

Merged
merged 1 commit into from
Feb 8, 2023
Merged

feature: weighted serve calls #135

merged 1 commit into from
Feb 8, 2023

Conversation

rustatian
Copy link
Member

Reason for This PR

closes: roadrunner-server/roadrunner#1452

Description of Changes

  • Sort vertices by their weight for the serve function calls.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added C-Enhancement Category: enhancement A-Algorithms Area: Algoritms area, meaning all related to the Algos labels Feb 8, 2023
@rustatian rustatian requested a review from wolfy-j February 8, 2023 18:51
@rustatian rustatian self-assigned this Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #135 (2f7e53a) into master (780bdb9) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   74.80%   75.19%   +0.39%     
==========================================
  Files          19       19              
  Lines         893      899       +6     
==========================================
+ Hits          668      676       +8     
+ Misses        195      193       -2     
  Partials       30       30              
Impacted Files Coverage Δ
serve.go 100.00% <100.00%> (ø)
graph/vertex.go 100.00% <0.00%> (+25.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rustatian rustatian merged commit fb63482 into master Feb 8, 2023
@rustatian rustatian deleted the feature/weighted-serve branch February 8, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Algorithms Area: Algoritms area, meaning all related to the Algos C-Enhancement Category: enhancement
Projects
No open projects
Archived in project
1 participant