-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: remove semaphores, add go 1.23 support #180
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Warning Rate limit exceeded@rustatian has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 38 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes involve modifications to various files in the codebase, including updates to GitHub Actions workflows, test functions, and dependency management in the Go module files. Key alterations include renaming a job in the workflow, shifting from assertion libraries to manual failure handling in tests, and simplifying dependency declarations. Additionally, concurrency control in the Changes
Sequence Diagram(s)sequenceDiagram
participant Test
participant Function
participant WaitGroup
Test->>Function: Call Test Function
Function->>WaitGroup: Initialize WaitGroup
Function->>Function: Execute Goroutines
Function->>WaitGroup: wg.Done() for each completion
WaitGroup->>Test: Wait for all goroutines to finish
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit
Chores
go.mod
file.go.mod
file for the testing module.Refactor
stop
method by switching to a wait group approach.Tests