Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal.go: make Service interface optional to implement #46

Merged
merged 4 commits into from
Oct 12, 2020
Merged

internal.go: make Service interface optional to implement #46

merged 4 commits into from
Oct 12, 2020

Conversation

rustatian
Copy link
Member

No description provided.

@rustatian rustatian added the C-Enhancement Category: enhancement label Oct 12, 2020
@rustatian rustatian added this to the 1.0.0-beta8 milestone Oct 12, 2020
@rustatian rustatian requested a review from wolfy-j October 12, 2020 16:12
@rustatian rustatian self-assigned this Oct 12, 2020
@rustatian
Copy link
Member Author

resolves #42

@rustatian
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 12, 2020

Build succeeded:

@bors bors bot merged commit cc9f653 into master Oct 12, 2020
@bors bors bot deleted the make_serve_and_stop_optional branch October 12, 2020 17:07
@rustatian rustatian linked an issue Oct 24, 2020 that may be closed by this pull request
Simplify service def #28
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy-j wolfy-j wolfy-j approved these changes

Assignees

@rustatian rustatian

Labels
C-Enhancement Category: enhancement
Projects
None yet
Milestone
1.0.0-beta8
Development

Successfully merging this pull request may close these issues.

Simplify service def
2 participants
@rustatian @wolfy-j