feature: allow specifying wildcards in the grpc.proto setting #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @MaxSem 👋🏻 Oh, I never saw this feature request 😢 Next time if that is something related to the server, please, send it to the https://github.com/roadrunner-server/roadrunner repository 👍🏻 |
rustatian
reviewed
May 17, 2023
rustatian
reviewed
May 17, 2023
MaxSem
force-pushed
the
proto-wildcards
branch
2 times, most recently
from
2be4e23
to
4c647f5
Compare
Signed-off-by: Max Semenik <maxsem.wiki@gmail.com>
|
Thanks @MaxSem 👍🏻 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
ref: roadrunner-php/grpc#14
In large projects, maintaining the list of protofiles becomes a chore, allow using filename wildcards (e.g. path/to/*.proto)
Description of Changes
Expand wildcards in Config.InitDefaults()
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.