-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: edge case where empty value overwrite existing value #87
Merged
rustatian
merged 8 commits into
roadrunner-server:master
from
xprotocol-org:fix-post-form-bug
Jan 25, 2023
Merged
fix: edge case where empty value overwrite existing value #87
rustatian
merged 8 commits into
roadrunner-server:master
from
xprotocol-org:fix-post-form-bug
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey 👋🏻, great work @tungfinblox, thanks 👍🏻 |
rustatian
reviewed
Jan 24, 2023
Everything else looks good (mmm generics 😆), nice job, thanks 👍🏻 |
Thank you. I updated it :D |
6 tasks
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
We found another edge case where
http
package can potentially wrongly overwrite dataLet's say that we have a form like this:
Because iterating over map in Go is random so this case might not happen all the time. But when it happens,
data under
name
key will be empty string which in our case removes all the relationships in Laravel backpack.I also refactor the test cases to be shorter and with better description.
Description of Changes
Fix one more edge case where empty value can potentially overwrite existing value.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
git commit -s
).CHANGELOG.md
.