Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bash): recognize aarch64 as arm64 #1463

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

daniellienert
Copy link
Contributor

@daniellienert daniellienert commented Feb 14, 2023

Reason for This PR

Recognize aarch64 as stated on alpine linux in docker on an Apple M1

Description of Changes

[Author TODO: add description of changes.]

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian changed the title TASK: Recognize aarch64 as arm64 chore(bash): recognize aarch64 as arm64 Feb 14, 2023
@rustatian rustatian self-requested a review February 14, 2023 23:09
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Feb 14, 2023
@rustatian rustatian added this to the v2023.1 milestone Feb 14, 2023
@rustatian
Copy link
Member

Hey, @daniellienert 👋🏻 Thanks for the contribution ❤️

The fix seems valid to me, but I don't have an aarch64 platform to test it 😿 Might be you have already tested it? 🙏🏻

@daniellienert
Copy link
Contributor Author

@rustatian sure 😉

with and without the patch

[www-data@9cffde304615 ~/app]
# curl --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/daniellienert/roadrunner/master/download-latest.sh | sh
ERROR: RoadRunner binary is not available for your OS distribution or your architecture yet.

However, you can easily compile the binary from the source files.
Follow the steps at the page ("Source" tab): TODO
[www-data@9cffde304615 ~/app]
# curl --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/daniellienert/roadrunner/task/aarch64/download-latest.sh | sh
Downloading RoadRunner binary 2.12.2 for linux, architecture arm64...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 12.2M  100 12.2M    0     0  4587k      0  0:00:02  0:00:02 --:--:-- 7039k
RoadRunner 2.12.2 archive successfully downloaded as roadrunner-2.12.2-linux-arm64.tar.gz
[www-data@9cffde304615 ~/app]
# uname -m
aarch64

@rustatian
Copy link
Member

Excellent, thank you, @daniellienert 👍🏻

@rustatian rustatian merged commit b834b53 into roadrunner-server:master Feb 15, 2023
@rustatian rustatian mentioned this pull request Feb 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants