-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v2024.2.1
#2001
release: v2024.2.1
#2001
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces version Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- go.mod (6 hunks)
Additional context used
Markdownlint
CHANGELOG.md
5-5: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
5-5: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
9-9: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
12-12: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
Additional comments not posted (2)
CHANGELOG.md (1)
3-18
: LGTM!The changelog entry for version
v2024.2.1
looks great! It provides a clear and concise summary of the notable changes, with helpful categorization and links to relevant PRs and issues for more details. The content aligns well with the stated PR objectives.Tools
Markdownlint
5-5: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time(MD001, heading-increment)
5-5: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
9-9: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
12-12: Punctuation: ':'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
go.mod (1)
5-5
: Dependency updates and compatibility verificationThe
go.mod
file has undergone a significant number of dependency version updates, including the Go toolchain itself and variousroadrunner-server
modules. Updating dependencies to newer versions can bring benefits such as bug fixes, security patches, and performance improvements. However, it's crucial to ensure that these updates are compatible with the codebase and don't introduce any breaking changes.A few points to consider:
What is the specific reason for updating the Go toolchain from version 1.23.0 to 1.23.1? Are there any particular improvements or fixes in this version that are relevant to the project?
Given the extensive updates across multiple dependencies, it's important to run comprehensive tests and perform thorough testing to verify that the updated dependencies integrate smoothly and don't cause any unexpected issues or breaking changes.
The presence of local development paths for the
temporal
andgrpc
plugins suggests ongoing custom development work. Can you provide some context on the specific modifications or features being developed for these plugins and how they relate to the overall project?Overall, the dependency updates seem to be part of a general maintenance effort to keep the project up to date with the latest versions. Just ensure that proper testing is done to maintain stability and compatibility.
Also applies to: 13-13, 15-20, 22-23, 25-52, 60-63, 74-74, 78-78, 81-86, 89-93, 118-118, 121-121, 151-151, 153-153, 155-156, 167-167, 194-205, 208-208, 211-211, 216-220, 222-223, 225-230
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Reason for This PR
Description of Changes
🚀 v2024.2.1 🚀
OTEL
plugin:Endpoint
andHeaders
for gRPC if they're empty: PR, Support standardOTEL
exporter protocol environment variables: PR. (thanks @devnev)RoadRunner-Temporal
plugin:AMQP
driver:redial_timeout
was not respected when dynamically creating pipeline. BUG, (thanks @algirdasci)🧹 Chore:
Velox
Dockerfile).License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit
New Features
OTEL
plugin with improved efficiency for gRPC connections and support for standard exporter protocol environment variables.Bug Fixes
RoadRunner-Temporal
plugin's gRPC client.redial_timeout
issue in theAMQP
driver during dynamic pipeline creation.Chores