Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v2024.2.1 #2001

Merged
merged 3 commits into from
Sep 12, 2024
Merged

release: v2024.2.1 #2001

merged 3 commits into from
Sep 12, 2024

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Sep 5, 2024

Reason for This PR

  • Bugfix release cycle.

Description of Changes

🚀 v2024.2.1 🚀

OTEL plugin:

  • 🔥: Several improvements by @devnev: Do not set Endpoint and Headers for gRPC if they're empty: PR, Support standard OTEL exporter protocol environment variables: PR. (thanks @devnev)

RoadRunner-Temporal plugin:

  • 🐛: gRPC client closed too early after shutdown: BUG. (thanks @kkosowski-p)

AMQP driver:

  • 🐛: redial_timeout was not respected when dynamically creating pipeline. BUG, (thanks @algirdasci)

🧹 Chore:

  • 🧑‍🏭: All plugins were updated to Go 1.23 (including Velox Dockerfile).

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • New Features

    • Enhanced OTEL plugin with improved efficiency for gRPC connections and support for standard exporter protocol environment variables.
  • Bug Fixes

    • Resolved premature shutdown issue in the RoadRunner-Temporal plugin's gRPC client.
    • Fixed redial_timeout issue in the AMQP driver during dynamic pipeline creation.
  • Chores

    • Updated all plugins to Go 1.23.1, ensuring compatibility with the latest Go version and enhancing performance and security.
    • Updated multiple dependencies to newer versions for improved functionality and security.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Sep 5, 2024
@rustatian rustatian requested a review from wolfy-j September 5, 2024 17:08
@rustatian rustatian self-assigned this Sep 5, 2024
Copy link
Contributor

coderabbitai bot commented Sep 5, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces version v2024.2.1, featuring enhancements and bug fixes across various plugins and drivers. Key improvements include updates to the OTEL plugin for gRPC connections, bug fixes in the RoadRunner-Temporal plugin, and adjustments in the AMQP driver. The go.mod file reflects updates to the Go toolchain and multiple dependency versions, ensuring compatibility and incorporating recent changes across libraries. Overall, the modifications enhance functionality and reliability without altering exported or public entity declarations.

Changes

File Change Summary
CHANGELOG.md Introduced version v2024.2.1, detailing enhancements and bug fixes for plugins and drivers.
go.mod Updated Go toolchain from 1.23.0 to 1.23.1 and incremented multiple dependencies to newer versions.

Possibly related PRs

🐇 In the meadow, changes bloom bright,
With plugins enhanced, oh what a sight!
The code now dances, bugs take flight,
Dependencies updated, all feels right.
A hop and a skip, we celebrate here,
With joyful hearts, we cheer and cheer! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian marked this pull request as ready for review September 12, 2024 15:55
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e1a1a90 and 7a50384.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • go.mod (6 hunks)
Additional context used
Markdownlint
CHANGELOG.md

5-5: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


5-5: Punctuation: ':'
Trailing punctuation in heading

(MD026, no-trailing-punctuation)


9-9: Punctuation: ':'
Trailing punctuation in heading

(MD026, no-trailing-punctuation)


12-12: Punctuation: ':'
Trailing punctuation in heading

(MD026, no-trailing-punctuation)

Additional comments not posted (2)
CHANGELOG.md (1)

3-18: LGTM!

The changelog entry for version v2024.2.1 looks great! It provides a clear and concise summary of the notable changes, with helpful categorization and links to relevant PRs and issues for more details. The content aligns well with the stated PR objectives.

Tools
Markdownlint

5-5: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)


5-5: Punctuation: ':'
Trailing punctuation in heading

(MD026, no-trailing-punctuation)


9-9: Punctuation: ':'
Trailing punctuation in heading

(MD026, no-trailing-punctuation)


12-12: Punctuation: ':'
Trailing punctuation in heading

(MD026, no-trailing-punctuation)

go.mod (1)

5-5: Dependency updates and compatibility verification

The go.mod file has undergone a significant number of dependency version updates, including the Go toolchain itself and various roadrunner-server modules. Updating dependencies to newer versions can bring benefits such as bug fixes, security patches, and performance improvements. However, it's crucial to ensure that these updates are compatible with the codebase and don't introduce any breaking changes.

A few points to consider:

  1. What is the specific reason for updating the Go toolchain from version 1.23.0 to 1.23.1? Are there any particular improvements or fixes in this version that are relevant to the project?

  2. Given the extensive updates across multiple dependencies, it's important to run comprehensive tests and perform thorough testing to verify that the updated dependencies integrate smoothly and don't cause any unexpected issues or breaking changes.

  3. The presence of local development paths for the temporal and grpc plugins suggests ongoing custom development work. Can you provide some context on the specific modifications or features being developed for these plugins and how they relate to the overall project?

Overall, the dependency updates seem to be part of a general maintenance effort to keep the project up to date with the latest versions. Just ensure that proper testing is done to maintain stability and compatibility.

Also applies to: 13-13, 15-20, 22-23, 25-52, 60-63, 74-74, 78-78, 81-86, 89-93, 118-118, 121-121, 151-151, 153-153, 155-156, 167-167, 194-205, 208-208, 211-211, 216-220, 222-223, 225-230

CHANGELOG.md Show resolved Hide resolved
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian merged commit 651cb40 into master Sep 12, 2024
12 of 13 checks passed
@rustatian rustatian deleted the release/v2024.2.1 branch September 12, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant