[CLOSED] Fix errors log buffer lost

[dhopkalo]

When I created my own worker process and use the code example for the push error to the rr server for workers

    } catch (\Throwable $e) {
        $worker->getWorker()->error((string)$e);
    }

I don't see my original error only the next errors:

2021-05-26T16:35:46.711+0300    DEBUG   server          server/plugin.go:225    worker destructed       {"pid": 24906}
2021-05-26T16:35:46.725+0300    ERROR   server          server/plugin.go:238    worker_watcher_wait: signal: killed; process_wait: signal: killed
github.com/spiral/roadrunner/v2/plugins/server.(*Plugin).collectEvents
        github.com/spiral/roadrunner/v2@v2.2.1/plugins/server/plugin.go:238
github.com/spiral/roadrunner/v2/pkg/events.(*HandlerImpl).Push
        github.com/spiral/roadrunner/v2@v2.2.1/pkg/events/general.go:37
github.com/spiral/roadrunner/v2/pkg/worker_watcher.(*workerWatcher).wait
        github.com/spiral/roadrunner/v2@v2.2.1/pkg/worker_watcher/worker_watcher.go:235
github.com/spiral/roadrunner/v2/pkg/worker_watcher.(*workerWatcher).addToWatch.func1
        github.com/spiral/roadrunner/v2@v2.2.1/pkg/worker_watcher/worker_watcher.go:260
2021-05-26T16:35:47.278+0300    DEBUG   server          server/plugin.go:223    worker constructed      {"pid": 24965}

I think that process killed before error buffer has been clean.

I also find out that http.pool.debug=true make it works ok but it not good idea for the production proposal

then I try to search for cracking changes and find out that version < 2.0.2 work ok but 2.0.3+ have this bug

I did code diff between this two version

and find out that it added some if that kill a worker process that has the state not equal to worker.StateReady
but in my case when I send an error invocation to the push, it has worker.stateWorking and if we just kill it I think it lost all the output date before it can be flushed to the main rr stderr or stdout pipes.

#691

[codecov]

Codecov Report

Merging #690 (af4d36d) into master (8237737) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   68.81%   68.81%           
=======================================
  Files          80       80           
  Lines        3794     3794           
=======================================
  Hits         2611     2611           
  Misses        838      838           
  Partials      345      345           

Impacted Files	Coverage Δ
pkg/worker_watcher/worker_watcher.go	85.71% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8237737...af4d36d. Read the comment docs.

[rustatian]

Hey @drefixs. Thanks for the PR.

1. Sorry, but this is not a solution to the described problem. It's ok, that this solution works for you, but imagine a case when a worker can't be stopped by our controlled stop signal because it's frozen. This will lead to zombie workers who will always be in the working state. So, just replacing Kill with Stop will not work here. I need to think about how to solve your problem gracefully. Also, this is a question, why the worker on Push operations was still in the working state.
2. Why you ignored the PR template?