Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): return nil if there are no workers in the requested plugin #699

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

rustatian
Copy link
Member

Reason for This PR

closes: #686

Description of Changes

  • Return nil instead of error if there are no workers in the requested plugin.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the B-regression Bug: regression bugs label Jun 2, 2021
@rustatian rustatian added this to the 2.3.0 milestone Jun 2, 2021
@rustatian rustatian requested a review from wolfy-j June 2, 2021 17:59
@rustatian rustatian self-assigned this Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #699 (42c0d32) into master (a99c14a) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #699      +/-   ##
==========================================
+ Coverage   68.95%   69.19%   +0.24%     
==========================================
  Files          91       91              
  Lines        4422     4422              
==========================================
+ Hits         3049     3060      +11     
+ Misses        974      967       -7     
+ Partials      399      395       -4     
Impacted Files Coverage Δ
plugins/informer/plugin.go 100.00% <100.00%> (+13.33%) ⬆️
plugins/informer/rpc.go 100.00% <100.00%> (+25.00%) ⬆️
pkg/bst/bst.go 82.85% <0.00%> (+1.42%) ⬆️
plugins/redis/fanin.go 86.66% <0.00%> (+6.66%) ⬆️
plugins/websockets/pool/workers_pool.go 77.08% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99c14a...42c0d32. Read the comment docs.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian merged commit 9c01e7a into master Jun 2, 2021
@bors bors bot deleted the bug/workers.list_returns_wrong_plugins branch June 2, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-regression Bug: regression bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] rr workers not working in Laravel Octane
1 participant