Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis, ws): redis driver not available #723

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Jun 14, 2021

Reason for This PR

closes: #720

Description of Changes

  • Rework Redis driver
  • Update PubSub provider interface helper
  • Goridge 3.1.4

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added B-bug Bug: bug, exception B-missing feature Bug: missing feature after implementation A-plugin Area: module labels Jun 14, 2021
@rustatian rustatian requested a review from wolfy-j June 14, 2021 13:41
@rustatian rustatian self-assigned this Jun 14, 2021
@rustatian rustatian added this to the 2.3.1 milestone Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #723 (9748651) into master (dc8ed20) will decrease coverage by 0.30%.
The diff coverage is 57.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   67.59%   67.29%   -0.31%     
==========================================
  Files          92       92              
  Lines        4725     4797      +72     
==========================================
+ Hits         3194     3228      +34     
- Misses       1107     1147      +40     
+ Partials      424      422       -2     
Impacted Files Coverage Δ
plugins/kv/drivers/boltdb/plugin.go 72.22% <ø> (ø)
plugins/kv/drivers/memcached/plugin.go 58.33% <ø> (ø)
plugins/kv/drivers/memory/plugin.go 77.77% <ø> (ø)
plugins/redis/kv.go 60.71% <ø> (ø)
plugins/kv/plugin.go 43.42% <38.09%> (ø)
plugins/redis/clients.go 48.21% <48.21%> (ø)
plugins/redis/plugin.go 65.00% <61.53%> (+2.23%) ⬆️
plugins/websockets/plugin.go 54.36% <62.06%> (-0.13%) ⬇️
plugins/redis/pubsub.go 62.35% <62.35%> (ø)
plugins/memory/plugin.go 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8ed20...9748651. Read the comment docs.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian changed the title fix(bug): redis driver not available fix(redis, ws): redis driver not available Jun 14, 2021
@rustatian rustatian merged commit a38a4e6 into master Jun 14, 2021
@bors bors bot deleted the fix/update_redis_plugin branch June 14, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-plugin Area: module B-bug Bug: bug, exception B-missing feature Bug: missing feature after implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] KV redis driver not available
1 participant