Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boltdb): fix boltdb permissions, interval, config bugs #724

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

rustatian
Copy link
Member

Reason for This PR

closes: #719
closes: #718
closes: #717

Description of Changes

  • Fix interval initialization
  • Fix default user permissions for the boltdb file (777 -> 0777)
  • Add timeout when trying to open the same boltdb file from different processes.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the B-regression Bug: regression bugs label Jun 14, 2021
@rustatian rustatian added this to the 2.3.1 milestone Jun 14, 2021
@rustatian rustatian requested a review from wolfy-j June 14, 2021 14:36
@rustatian rustatian self-assigned this Jun 14, 2021
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #724 (fe41962) into master (a38a4e6) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   67.29%   67.47%   +0.18%     
==========================================
  Files          92       92              
  Lines        4797     4800       +3     
==========================================
+ Hits         3228     3239      +11     
+ Misses       1147     1143       -4     
+ Partials      422      418       -4     
Impacted Files Coverage Δ
plugins/kv/drivers/boltdb/config.go 71.42% <100.00%> (+71.42%) ⬆️
plugins/kv/drivers/boltdb/driver.go 52.45% <100.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38a4e6...fe41962. Read the comment docs.

@rustatian rustatian merged commit aeaf679 into master Jun 14, 2021
@bors bors bot deleted the fix/boltdb_plugin branch June 14, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-regression Bug: regression bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] KV two differend boltdb buckets in one storage [BUG] KV boltdb permissions [BUG] KV boltdb interval
2 participants