Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

chore: worker_watcher refactoring #36

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Jul 1, 2022

Reason for This PR

closes: roadrunner-server/roadrunner#1180

Description of Changes

  • Refactor worker_watcher, and remove unused or misused features.
  • Prevent from allocating zombie processes.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Jul 1, 2022
@rustatian rustatian requested a review from wolfy-j July 1, 2022 00:41
@rustatian rustatian self-assigned this Jul 1, 2022
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #36 (f5db2a6) into master (b9bf72a) will increase coverage by 0.32%.
The diff coverage is 56.62%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   77.83%   78.15%   +0.32%     
==========================================
  Files          23       24       +1     
  Lines        2161     2129      -32     
==========================================
- Hits         1682     1664      -18     
+ Misses        398      382      -16     
- Partials       81       83       +2     
Impacted Files Coverage Δ
pool/options.go 0.00% <ø> (ø)
pool/allocator.go 86.84% <28.57%> (-13.16%) ⬇️
worker_watcher/container/channel/vec.go 76.76% <33.33%> (-2.81%) ⬇️
worker_watcher/worker_watcher.go 81.74% <47.36%> (+0.61%) ⬆️
pool/errEncoder.go 55.26% <55.26%> (ø)
ipc/pipe/pipe_factory.go 76.28% <100.00%> (+0.75%) ⬆️
pool/static_pool.go 70.52% <100.00%> (+2.12%) ⬆️
pool/stream_pool.go 65.09% <100.00%> (+2.33%) ⬆️
worker/sync_worker.go 80.00% <100.00%> (+0.09%) ⬆️
worker/worker.go 84.61% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9bf72a...f5db2a6. Read the comment docs.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[🐛 BUG]: RR hangs on the wait4 syscall when rr reset is using at the same time
1 participant