Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Twilio backend #16

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Add Twilio backend #16

merged 2 commits into from
Feb 19, 2021

Conversation

tubaman
Copy link
Contributor

@tubaman tubaman commented Feb 19, 2021 •
edited by roaldnefs
Loading

Here's a backend for Twilio. I haven't had the chance to run the tests yet. Hopefully your CI will run them.

Fixes #7

@tubaman tubaman force-pushed the add_twilio branch 3 times, most recently from 9c40575 to 79b8f13 Compare February 19, 2021 02:51
@roaldnefs
Copy link
Owner

Thanks @tubaman for your contribution!
I'll try to test the newly added backend later this weekend.

@roaldnefs roaldnefs added the enhancement New feature or request label Feb 19, 2021
@roaldnefs roaldnefs self-requested a review February 19, 2021 07:13
@roaldnefs
docs: add CHANGELOG.md entry for Twilio backend
a73f8cd 
Signed-off-by: Roald Nefs <info@roaldnefs.com>
roaldnefs
roaldnefs approved these changes Feb 19, 2021
View reviewed changes
Copy link
Owner

@roaldnefs roaldnefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just created a Twilio account to test this PR, works perfectly!

@roaldnefs roaldnefs merged commit ead09d4 into roaldnefs:main Feb 19, 2021
@roaldnefs
Copy link
Owner

Just release v0.5.0 which includes the Twilio backend, see: https://pypi.org/project/django-sms/0.5.0/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaldnefs roaldnefs roaldnefs approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Twilio backend
2 participants
@tubaman @roaldnefs