fix osx on travis #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @musm, Thanks for your help! It looked to me like OSX was already passing (travis) and this commit is now making it fail due to trying to install hdf5 Error: hdf5 1.10.2_1 is already installed
To upgrade to 1.10.4, run `brew upgrade hdf5`
The command "if [ $TRAVIS_OS_NAME = osx ]; then brew install gcc; brew link --overwrite gcc; brew install hdf5; fi" failed and exited with 1 during .However, I don't have OSX that I can easily test on. Can you describe what the issue is. And I will try and get hold of an OSX computer to reproduce the issue. |
|
Also I have plans to update this package. If you have any features you need that arent available yet, feel free to create an issue and I will look at it. |
|
@musm I now see you are one of the HDF5 maintainers. Any idea why the change you made didn't work here? |
|
Ok found the issue. It was my hack that was breaking the build. Now it works on OSX master. Will tag now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
could we tag after?