Obj ID typing correction

robamu-org · May 5, 2024 · 9aec29a · 9aec29a
1 parent 7d726c4
commit 9aec29a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ Starting from v4.0.0, this project adheres to [Semantic Versioning](http://semve
 ## Changed
 
 - Renamed `FsfwTmTcPrinter.get_validity_buffer` to `FsfwTmTcPrinter.get_validity_buffer_str`
+- Renamed `ObjectId<$TY>.from_bytes` to `ObjectId<$TY>.from_bytes_typed` to avoid invalid override.
 
 ## Added
 

diff --git a/tmtccmd/util/obj_id.py b/tmtccmd/util/obj_id.py
@@ -68,7 +68,7 @@ def __repr__(self):
         )
 
     @classmethod
-    def from_bytes(cls, obj_id_as_bytes: bytes) -> ObjectIdU32:
+    def from_bytes_typed(cls, obj_id_as_bytes: bytes) -> ObjectIdU32:
         obj_id = ObjectIdU32(obj_id=0)
         obj_id.obj_id = obj_id_as_bytes
         return obj_id
@@ -88,7 +88,7 @@ def __repr__(self):
         )
 
     @classmethod
-    def from_bytes(cls, obj_id_as_bytes: bytes) -> ObjectIdU16:
+    def from_bytes_typed(cls, obj_id_as_bytes: bytes) -> ObjectIdU16:
         obj_id = ObjectIdU16(obj_id=0)
         obj_id.obj_id = obj_id_as_bytes
         return obj_id
@@ -108,7 +108,7 @@ def __repr__(self):
         )
 
     @classmethod
-    def from_bytes(cls, obj_id_as_bytes: bytes) -> ObjectIdU8:
+    def from_bytes_typed(cls, obj_id_as_bytes: bytes) -> ObjectIdU8:
         obj_id = ObjectIdU8(obj_id=0)
         obj_id.obj_id = obj_id_as_bytes
         return obj_id