Add missing polyfill options for ES2022 (#75)

* add * test
robatwilliams · May 12, 2023 · 00be982 · 00be982
1 parent 7c97890
commit 00be982
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/packages/eslint-plugin-ecmascript-compat/lib/features/es2022.js b/packages/eslint-plugin-ecmascript-compat/lib/features/es2022.js
@@ -29,10 +29,12 @@ module.exports = [
   {
     ruleConfig: { definition: esPlugin.rules['no-error-cause'] },
     compatFeatures: [compatData.javascript.builtins.Error.Error.options_cause_parameter],
+    polyfill: 'Error.cause',
   },
   {
     ruleConfig: { definition: esPlugin.rules['no-object-hasown'] },
     compatFeatures: [compatData.javascript.builtins.Object.hasOwn],
+    polyfill: 'Object.hasOwn',
   },
   {
     ruleConfig: { definition: esPlugin.rules['no-private-in'] },

diff --git a/packages/eslint-plugin-ecmascript-compat/lib/features/es2022.spec.js b/packages/eslint-plugin-ecmascript-compat/lib/features/es2022.spec.js
@@ -21,6 +21,14 @@ ruleTester.run('compat', require('../rule'), {
       code: '"Foo".at(1);',
       options: [{ polyfills: ['{Array,String,TypedArray}.prototype.at'] }],
     },
+    {
+      code: "new Error('message', { cause: originalError })",
+      options: [{ polyfills: ['Error.cause'] }],
+    },
+    {
+      code: "Object.hasOwn(obj, 'prop');",
+      options: [{ polyfills: ['Object.hasOwn'] }],
+    },
   ],
   invalid: [
     {

diff --git a/packages/eslint-plugin-ecmascript-compat/lib/rule.js b/packages/eslint-plugin-ecmascript-compat/lib/rule.js
@@ -18,14 +18,17 @@ module.exports = {
             items: {
               type: 'string',
               enum: [
+                // This list is hard-coded so it can serve as documentation
                 'globalThis',
                 '{Array,String,TypedArray}.prototype.at',
                 'Array.prototype.flat',
                 'Array.prototype.flatMap',
                 'Array.prototype.includes',
+                'Error.cause',
                 'Object.entries',
                 'Object.fromEntries',
                 'Object.getOwnPropertyDescriptors',
+                'Object.hasOwn',
                 'Object.values',
                 'Promise.prototype.allSettled',
                 'Promise.prototype.any',

diff --git a/packages/eslint-plugin-ecmascript-compat/lib/rule.spec.js b/packages/eslint-plugin-ecmascript-compat/lib/rule.spec.js
@@ -0,0 +1,11 @@
+const features = require('./features');
+const rule = require('./rule');
+
+test('polyfills accepted in the schema exactly match those supported', () => {
+  const schemaPolyfills = rule.meta.schema[0].properties.polyfills.items.enum;
+  const supportedPolyfills = features.flatMap((feature) =>
+    feature.polyfill ? [feature.polyfill] : []
+  );
+
+  expect(schemaPolyfills.sort()).toEqual(supportedPolyfills.sort());
+});