Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not taking into account private class methods compatibility #87

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix not taking into account private class methods compatibility #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c6b399
Fix not taking into account private class methods compatibility
robatwilliams Jan 17, 2024
4a06a1b
Update test which was meant to be for private field
robatwilliams Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/eslint-plugin-ecmascript-compat/lib/features/es2022.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ module.exports = [
compatData.javascript.classes.public_class_fields,
compatData.javascript.classes.private_class_fields,
compatData.javascript.classes.static_class_fields,
compatData.javascript.classes.private_class_methods,
],
},
{
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-plugin-ecmascript-compat/lib/features/es2022.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ ruleTester.run('compat', require('../rule'), {
errors: [{ message: "ES2022 'Array.prototype.at' method is forbidden." }],
},
{
code: 'class A { a = 0 }',
errors: [{ message: "ES2020 field 'a' is forbidden." }],
code: 'class A { #a = 0 }',
errors: [{ message: 'ES2020 private field #a is forbidden.' }],
},
{
code: 'class A { static { } }',
Expand Down