-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 3 conversion Xcode 8 GM #228
Conversation
Rockin' - I think this will also need the travis file updating to Xcode 8 - it's currently 7.3 |
@orta: I haven't bothered yet with the travis file as Quick and Nimble are still not Swift 3 ready. As soon as they have it working we can start migrating the tests and configuring travis to use the xcode8 image. |
👌 cool |
Also, I just realised that the |
Quick and Nimble have been successfully migrated to Swift 3 (Xcode 8 Beta 6). I'm gonna start fixing the tests for this branch later today 🤘🏼 |
🤘🏼 |
👍 |
I've just merged #203 to master, so you might have a little bit more porting to do - sorry! |
No worries. I'll rebase this branch and port the new code. |
3bda789
to
bceb091
Compare
I have converted the tests to Swift 3 and all is well except for the Priority operator which has a problem of precedence. I have tried fixing it as per SE-0077 but it seems that I got it wrong as the following test fails to build:
I will take a deeper look into that later today and hopefully a commit will follow 😉 |
XCode 8 GM didn't break anything on this branch 😮 |
Should also consider switching these deps to CocoaPods, every time I look at the build fails it's because of Carthage using the GitHub API Anyway, @raphaelcruzeiro - is the |
@orta I pushed a commit switching to CocoaPods. Hopefully travis will at least get to trying to build the tests. About the |
Hrm, I haven't looked at Swift 3 but I remember this tweet perhaps you can try making the name |
I can rename the precedence group to avoid possible name clashes but this will most likely not solve the operator problem. |
I've made a note and some PR changes in raphaelcruzeiro#1 |
… a problem with the priority operator `~` that will prevent the test project from building (commenting the faulty test will make the test project build and all other tests will pass).
…t follows the same standards from the standard library
…oid possible name clashes with other frameworks
6f975da
to
01906c8
Compare
Submitted another PR to hopefully fix CI - raphaelcruzeiro#2 |
More CI changes for Swift 3.0
88c1bb5
to
cbf57d1
Compare
Reference the workspace, and include tvOS in the CI
awww, we got one green |
@orta 🎉 |
OK, IMO this is good to go, will give it a look over tomorrow and give this a good to go, IMO this library has been used in production long enough that this should be the 1.0 given there there is now literally thousands of people relying on it in production |
The project builds and seems to run correctly. Still need to update Quick and Nimble and fix the tests.