Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config subscription #5

Merged
merged 4 commits into from
May 1, 2017
Merged

Config subscription #5

merged 4 commits into from
May 1, 2017

Conversation

robbawebba
Copy link
Owner

Observe package theme settings and update the editor themes when the package settings change.

  • If a user changes the daytime themes during the day (or when daytime is manually toggled), the editor will update to the newly specified themes.
  • If a user changes the nighttime themes during the night (or when nighttime is manually toggled), the editor will update to the newly specified themes.
  • If a user changes the daytime themes during the night (or vise versa), then the editor will not change themes right away because it is not the proper time.

@robbawebba robbawebba merged commit dc3d221 into develop May 1, 2017
@robbawebba robbawebba deleted the config-subscription branch October 22, 2017 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robbawebba