Fix issues #222 and #535. Enlarge the maximum size of UDP packet. #536
Conversation
… size of UDP packet.
|
@Noskthing Thanks for looking into this. What happens if the data you are sending is greater than Before I merge this would you mind adding unit tests?
You can look at the other TCP tests for an example. You can make a UDP serverSocket and clientSocket during setup, and then add tests for these cases:
|
|
Hi, I am sorry that if the data you are sending is greater than limit the socket will be closed but i neglect this error. Delegate will excute function udpSocketDidClose:withError: . I create new UDPTests in Shared but i don't know how to add to other projects. It just work in iOS project. I think udp is not a good idea when you try to send a large packet so that apple set the maximum size of udp buffer 9216 not 65535. I add some code annotation and wish it could help others. |
Source/GCD/GCDAsyncUdpSocket.h
Outdated
| * You must set it before the sockt is created otherwise it won't work. | ||
| * | ||
| **/ | ||
| - (uint32_t)maxSendBufferSize; |
There was a problem hiding this comment.
Should be uint16_t not uint32_t correct?
Source/GCD/GCDAsyncUdpSocket.m
Outdated
| - (uint32_t)maxSendBufferSize | ||
| { | ||
| __block uint32_t result = 0; | ||
|
|
There was a problem hiding this comment.
Also should be uint16_t here as well?
|
@Noskthing Also would you mind adding an additional test for the After those small changes I will merge because otherwise it looks good. 👍 |
|
Thanks for your correction! I have fixed these error and add tests for maxSendBufferSize. :) |
|
Awesome! Thank you |
ghost
mentioned this pull request
Fixes compiler warnings and data type errors, plus these specific fixes: * File descriptor leak - robbiehanson/CocoaAsyncSocket#522 * Fixes UDP connection issues with IPv6: robbiehanson/CocoaAsyncSocket#429 (comment) * Prevents truncating UDP packets: robbiehanson/CocoaAsyncSocket#222 * Allow UDP packet size above iOS default of 9216 bytes: robbiehanson/CocoaAsyncSocket#536 NOTE: We are holding back on updating to GCDAsyncSocket 7.6.2 because of reports that 7.6.1 may have introduced a crash: * see robbiehanson/CocoaAsyncSocket#579
Hi!
This branch fix issues #222( Don't trust GCD to give accurate UDP packet sizes) and #535(GCDAsyncUDPSocket can not send data when data is greater than 9K). The reason is that the default maximum size of the UDP buffer in iOS is 9216 bytes. So they can not send data if the size of data is grater than 9216 or packets can be silently truncated without any log.
I enlarge the maximum size of UDP packet by function setsockopt and change the value of max4ReceiveSize/max6ReceiveSize.
I test my changes and it works fine!