Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two compiler warnings and occurrences in code #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix two compiler warnings and occurrences in code #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b12cc8
Enable "Suspicious Implicit Conversions" warning and fix occurances
Mar 12, 2013
3905c2e
Enable "Hidden Local Variable" warning and fix occurance
Mar 12, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions KissXML/DDXMLElement.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,17 +156,17 @@ - (NSArray *)_elementsForName:(NSString *)name

if (uri == nil)
{
match = xmlStrEqual(child->name, xmlName);
match = (BOOL)xmlStrEqual(child->name, xmlName);
}
else
{
BOOL nameMatch = xmlStrEqual(child->name, xmlName);
BOOL localNameMatch = xmlStrEqual(child->name, xmlLocalName);
BOOL nameMatch = (BOOL)xmlStrEqual(child->name, xmlName);
BOOL localNameMatch = (BOOL)xmlStrEqual(child->name, xmlLocalName);

BOOL uriMatch = NO;
if (child->ns)
{
uriMatch = xmlStrEqual(child->ns->href, xmlUri);
uriMatch = (BOOL)xmlStrEqual(child->ns->href, xmlUri);
}

if (hasPrefix)
Expand Down Expand Up @@ -250,7 +250,6 @@ - (NSArray *)elementsForLocalName:(NSString *)localName URI:(NSString *)uri
}
else
{
NSString *prefix;
NSString *realLocalName;

[DDXMLNode getPrefix:&prefix localName:&realLocalName forName:localName];
Expand Down
4 changes: 4 additions & 0 deletions UnitTesting/KissXML.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,9 +312,11 @@
isa = XCBuildConfiguration;
buildSettings = {
ARCHS = "$(ARCHS_STANDARD_32_64_BIT)";
CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES;
GCC_C_LANGUAGE_STANDARD = c99;
GCC_OPTIMIZATION_LEVEL = 0;
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_SHADOW = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
HEADER_SEARCH_PATHS = /usr/include/libxml2;
MACOSX_DEPLOYMENT_TARGET = 10.6;
Expand All @@ -327,8 +329,10 @@
isa = XCBuildConfiguration;
buildSettings = {
ARCHS = "$(ARCHS_STANDARD_32_64_BIT)";
CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES;
GCC_C_LANGUAGE_STANDARD = c99;
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_SHADOW = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
HEADER_SEARCH_PATHS = /usr/include/libxml2;
MACOSX_DEPLOYMENT_TARGET = 10.6;
Expand Down