-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New section library #132
New section library #132
Conversation
I made the changes in file naming: I see that the docs build so I think that means that I caught all of the updates that needed to occur in the doc string examples, too. Shoot, I just realized that I will have to update all of the examples from @normanrichardson, too. Won't take too long once he is able to merge his PR. Should norman's PR be merged before this one? |
@connorferster yeah I think it makes sense to get #143 merged first then we can edit those files as needed in this PR. |
@robbievanleeuwen @Spectre5 I saw that the Lint checks were failing and so was sure to "blackify" all of the code in the directory. However, even after that, the linter is telling us that it would still modify files. I re-ran |
I'd bet that you are using a different version locally than in the CI. This is one reason I like to use poetry to freeze the version and use poetry also in the CI files to make sure the same version is used in CI as locally, not just for black but for any other future code checkers or linters too (isort, pylint, flake8, mypy, etc). Removes a lot of these types of headaches, especially if more linting tools get added in the future. And makes sure that all developers are using the same versions locally too. |
Yep I guess you have a different version of black locally as @Spectre5 suggested. I have the same output locally as the github action. Also there appear to be a few issues with the docs build. Another quick one with the sphinx-gallery - the mesh is not showing on any of the plots in the examples, e.g. see here. Don't have any experience with the gallery but maybe it's something to do with the image quality being saved? |
I'm guessing it is a resolution issue that @robbievanleeuwen has found. It you look closely, you can very faintly see an outline of the circle. Or a few edges in the second example output. |
Yet another option would be to allow passing |
It may also be caused by the alpha settings from the plot. Will check it out. |
As discussed in #75, a more orderly way of organising built-in geometries implemented in sectionproperties.
Consists of a new
library
module under thepre
module, with built-in geometries organised into files based on their application. Currently consists of the following:This also broke a fair number of examples in the docs which I have gone through and cleaned up.
#124 will also need to be slightly reworked to catch the new library structure.