Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CompoundGeometry offset perimeter (dilation creates overlapping geometry) #332

Merged
merged 10 commits into from
Jul 19, 2024
Merged

Fix CompoundGeometry offset perimeter (dilation creates overlapping geometry) #332

merged 10 commits into from
Jul 19, 2024

Commits on Oct 9, 2023

  1. Add test case for ballooning compound perimeter

    @robbievanleeuwen
    robbievanleeuwen committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2c6e4cf View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge branch 'master' into compound-offset-perimeter-fix

    @connorferster
    connorferster committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    20d232a View commit details
    Browse the repository at this point in the history

  2. feat: update algorithm for CompoundGeometry.offset_perimeter 

    - Offset now works with three or more equal-sized geometries stacked together (not just two)
- Fixed error in test calculation: A = pi * r**2, not A = pi * r**2 / 4
- Tests pass but more work needs to be done on the algorithm to deal with re-entrant corners (later date).
    @connorferster
    connorferster committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    b4acdb7 View commit details
    Browse the repository at this point in the history

  3. fix: update types in function signatures

    @connorferster
    connorferster committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    1b361a9 View commit details
    Browse the repository at this point in the history

  4. blackify

    @connorferster
    connorferster committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d94a47e View commit details
    Browse the repository at this point in the history

  5. updated type annotation to try and satisfy mypy

    @connorferster
    connorferster committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    2fce9d7 View commit details
    Browse the repository at this point in the history

  6. chore: update doc strings

    @connorferster
    connorferster committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    aec577d View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Lint geometry.py

    @robbievanleeuwen
    robbievanleeuwen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9b62c7b View commit details
    Browse the repository at this point in the history

  2. Ignore mypy errors

    @robbievanleeuwen
    robbievanleeuwen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b573433 View commit details
    Browse the repository at this point in the history

  3. Add second balloon test (3 rectangles)

    @robbievanleeuwen
    robbievanleeuwen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2067656 View commit details
    Browse the repository at this point in the history