Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot warping function only over section extents #345

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

robbievanleeuwen
Copy link
Owner

@TLCFEM - I made a few change to the warping function plot so that it only displays over the extent of the section. Do you think this is a better implementation? Consider this example:

from sectionproperties.pre.library import channel_section
from sectionproperties.analysis import Section
geom = channel_section(200, 100, 16, 8, 15, 8)
geom.create_mesh(3)
sec = Section(geom)
sec.calculate_frame_properties()
sec.plot_warping_function()

With the current implementation you get this:

This PR gives:

I feel like this is a better visualisation, however would you ever want to visualise the entire field, even outside the section extents?

@robbievanleeuwen robbievanleeuwen marked this pull request as ready for review October 13, 2023 12:46
@robbievanleeuwen robbievanleeuwen self-assigned this Oct 13, 2023
@robbievanleeuwen robbievanleeuwen added the bug Something isn't working label Oct 13, 2023
@TLCFEM
Copy link
Contributor

TLCFEM commented Oct 13, 2023

Yes, this is for sure the more correct solution. I was not thoughtful and just wanted to plot something to show the difference.

@robbievanleeuwen robbievanleeuwen merged commit 7ee9a82 into master Oct 13, 2023
14 checks passed
@robbievanleeuwen robbievanleeuwen deleted the fix-warping-plot branch October 13, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants