-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to swap in cytriangle #439
Conversation
Patch release v1.0.1 adds I can add typing this weekend to appease mypy if necessary. |
Thanks @m-clare, no need to add typing, I excluded @connorferster I have a few weeks off work starting next week so am happy to update to update the docs and merge. Also, we are now testing against |
I will merge this but then also ask: how do I check the benchmarks? |
Thanks @connorferster, there's a bit of info here about the benchmarks. Basically just runs a set of tests and gives some time info as output. I can have a look at these tomorrow, will just checkout the code before and after the PR merge to see if there's any significant changes. I'll also quickly update the docs where it references the old triangle library - should be pretty quick with a little |
BenchmarkingThese results are in no way scientific (run on a linux virtual machine with background tasks going running on my PC): Meshing
CytriangleTriangleAnalysisThis is a benchmark of the whole CytriangleTriangle |
Pull Request Check List
triangle
vscytriangle