Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1649 prepare preventive and subtractive rule editing #330

Merged
merged 17 commits into from
Nov 29, 2024
Merged

feature/mx-1649 prepare preventive and subtractive rule editing #330

merged 17 commits into from
Nov 29, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Nov 11, 2024 •
edited
Loading

PR Context

Added

  • add vocabulary and temporal unions and lookups to mex.common.types
  • add mex.common.fields with field type by class name lookups

Changes

  • set default empty rules to all of the rule-set models
  • pin pydantic to sub 2.10 (for now) because of breaking changes

Fixed

  • switch HTTP method for preview endpoint to POST
  • add optional values to variadic values for distribution models
  • make endpointDescription optional for variadic access platform models

cutoffthetop and others added 3 commits November 5, 2024 10:50
@cutoffthetop
Update connector.py
83c4eba 
Signed-off-by: Nicolas Drebenstedt <897972+cutoffthetop@users.noreply.github.com>
@cutoffthetop
Fix endpointDescription missing default
b5d8600 
Signed-off-by: Nicolas Drebenstedt <897972+cutoffthetop@users.noreply.github.com>
@cutoffthetop
more fixes and tests
3d7a57e
@cutoffthetop cutoffthetop mentioned this pull request Nov 12, 2024
Open
cutoffthetop and others added 13 commits November 12, 2024 12:39
mr-kamran-ali
mr-kamran-ali approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@mr-kamran-ali mr-kamran-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go! 🐰

@cutoffthetop cutoffthetop merged commit b1bb746 into main Nov 29, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1649-prep-editing branch November 29, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-kamran-ali mr-kamran-ali mr-kamran-ali approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @mr-kamran-ali