Fix restoring timeline position on refresh

robertodoering · Nov 26, 2022 · 14694c2 · 14694c2
1 parent 723ce16
commit 14694c2
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/lib/components/timeline/provider/timeline_provider.dart b/lib/components/timeline/provider/timeline_provider.dart
@@ -198,6 +198,13 @@ abstract class TimelineNotifier<T extends Object>
         if (id >= tweetId) {
           restoredTweet = tweets[i];
           restoredTweetIndex = i;
+
+          // Break when finding the exact tweet, otherwise look for an older one
+          // that is still newer than `tweetId`.
+          // This prevents refreshing to falsely identify older tweets as the
+          // refreshTweet if the `tweetId` is from a Tweet that has replies
+          // which pushed it up in the timeline.
+          if (id == tweetId) break;
         } else {
           break;
         }