Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Python 2.7.12+ for PC-BASIC 16.12 #24

Closed
robhagemans opened this issue Mar 11, 2017 · 2 comments
Closed

Require Python 2.7.12+ for PC-BASIC 16.12 #24

robhagemans opened this issue Mar 11, 2017 · 2 comments
Assignees
@robhagemans
Labels
bug enhancement

Comments

@robhagemans
Copy link
Owner

Older versions of Python make PC-BASIC crash due to http://bugs.python.org/issue22113
which was solved in 2.7.12:

  • Issue #22113: struct.pack_into() now supports new buffer protocol (in particular accepts writable memoryview).

Include requirement in docs, & installer. Check on startup and fail gracefully, avoid confusing crash message.
@robhagemans robhagemans self-assigned this Mar 11, 2017
This was referenced Oct 18, 2017
Closed
Closed
@robhagemans
Copy link
Owner Author

Mark as bug as this is causing unintuitive errors, e.g. #45 and #43

robhagemans added a commit that referenced this issue Dec 28, 2017
@robhagemans
update required package versions (also re issue #24)
1f67f24
robhagemans added a commit that referenced this issue Dec 28, 2017
@robhagemans
include python version in crash logs (re issue #24)
7235c1f
robhagemans added a commit that referenced this issue Dec 28, 2017
@robhagemans
require python 2.7.12+ at startup (fix issue #24)
cc74e2b
@robhagemans
Copy link
Owner Author

Fixed by cc74e2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robhagemans robhagemans

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robhagemans