Back out "Implement new feature flag system"

Summary: Original commit changeset: 0ba95803f61e Original Phabricator Diff: D52806730 bypass-github-export-checks changelog: [internal] internal Reviewed By: yungsters Differential Revision: D53113947 fbshipit-source-id: ace1222a861a739fcd3f4b0e12c135db47a93344
robhogan · Jan 26, 2024 · ffaeaba · ffaeaba
1 parent 31a8bc9
commit ffaeaba
Show file tree

Hide file tree

Showing 73 changed files with 4 additions and 3,126 deletions.
diff --git a/package.json b/package.json
@@ -21,8 +21,6 @@
     "flow": "flow",
     "format-check": "prettier --list-different \"./**/*.{js,md,yml,ts,tsx}\"",
     "format": "npm run prettier && npm run clang-format",
-    "featureflags-check": "cd packages/react-native && yarn featureflags-check",
-    "featureflags-update": "cd packages/react-native && yarn featureflags-update",
     "lint-ci": "./scripts/circleci/analyze_code.sh && yarn shellcheck",
     "lint-java": "node ./scripts/lint-java.js",
     "lint": "eslint .",

diff --git a/packages/react-native/React-Core.podspec b/packages/react-native/React-Core.podspec
@@ -129,7 +129,6 @@ Pod::Spec.new do |s|
   s.dependency "React-jsi"
   s.dependency "React-jsiexecutor"
   s.dependency "React-utils"
-  s.dependency "React-featureflags"
   s.dependency "SocketRocket", socket_rocket_version
   s.dependency "React-runtimescheduler"
   s.dependency "Yoga"

diff --git a/packages/react-native/ReactAndroid/build.gradle.kts b/packages/react-native/ReactAndroid/build.gradle.kts
@@ -526,7 +526,6 @@ android {
             "runtimeexecutor",
             "react_codegen_rncore",
             "react_debug",
-            "react_featureflags",
             "react_utils",
             "react_render_componentregistry",
             "react_newarchdefaults",
@@ -541,7 +540,6 @@ android {
             "jsi",
             "glog",
             "fabricjni",
-            "featureflagsjni",
             "react_render_mapbuffer",
             "yoga",
             "folly_runtime",

diff --git a/...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt b/...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt
diff --git a/...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsAccessor.kt b/...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsAccessor.kt
diff --git a/.../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt b/.../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt
diff --git a/...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt b/...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt
diff --git a/...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt b/...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
diff --git a/...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsForTests.kt b/...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsForTests.kt
diff --git a/...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt b/...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt
diff --git a/...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt b/...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt
diff --git a/packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt b/packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt
@@ -70,7 +70,6 @@ add_react_common_subdir(hermes/inspector-modern)
 add_react_common_subdir(react/renderer/runtimescheduler)
 add_react_common_subdir(react/debug)
 add_react_common_subdir(react/config)
-add_react_common_subdir(react/featureflags)
 add_react_common_subdir(react/renderer/animations)
 add_react_common_subdir(react/renderer/attributedstring)
 add_react_common_subdir(react/renderer/componentregistry)
@@ -119,7 +118,6 @@ add_react_android_subdir(src/main/jni/react/uimanager)
 add_react_android_subdir(src/main/jni/react/mapbuffer)
 add_react_android_subdir(src/main/jni/react/reactnativeblob)
 add_react_android_subdir(src/main/jni/react/fabric)
-add_react_android_subdir(src/main/jni/react/featureflags)
 add_react_android_subdir(src/main/jni/react/newarchdefaults)
 add_react_android_subdir(src/main/jni/react/hermes/reactexecutor)
 add_react_android_subdir(src/main/jni/react/hermes/instrumentation/)

diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/CMakeLists.txt b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/CMakeLists.txt
@@ -26,7 +26,6 @@ target_link_libraries(
         mapbufferjni
         react_codegen_rncore
         react_debug
-        react_featureflags
         react_render_animations
         react_render_attributedstring
         react_render_componentregistry

diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/featureflags/CMakeLists.txt b/packages/react-native/ReactAndroid/src/main/jni/react/featureflags/CMakeLists.txt