Skip to content

Commit

Permalink
remove useless assignment
Browse files Browse the repository at this point in the history
Signed-off-by: Rob Howley <howley.robert@gmail.com>
  • Loading branch information
robhowley committed Oct 30, 2024
1 parent 3025386 commit b7cedb7
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions sdk/python/feast/feature_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from fastapi.responses import JSONResponse
from google.protobuf.json_format import MessageToDict
from prometheus_client import Gauge, start_http_server
from pydantic import BaseModel, Field
from pydantic import BaseModel

import feast
from feast import proto_json, utils
Expand Down Expand Up @@ -71,7 +71,7 @@ class MaterializeIncrementalRequest(BaseModel):
class GetOnlineFeaturesRequest(BaseModel):
entities: Dict[str, List[Any]]
feature_service: Optional[str] = None
features: Optional[List[str]] = Field(default_factory=list)
features: Optional[List[str]] = None
full_feature_names: bool = False


Expand Down Expand Up @@ -119,10 +119,8 @@ async def lifespan(app: FastAPI):
dependencies=[Depends(inject_user_details)],
)
async def get_online_features(request: GetOnlineFeaturesRequest):
full_feature_names = request.full_feature_names
entity_rows = request.entities
# Initialize parameters for FeatureStore.get_online_features(...) call
if request.feature_service is not None:
if request.feature_service:
feature_service = store.get_feature_service(
request.feature_service, allow_cache=True
)
Expand Down Expand Up @@ -150,8 +148,8 @@ async def get_online_features(request: GetOnlineFeaturesRequest):

read_params = dict(
features=request.feature_service,
entity_rows=entity_rows,
full_feature_names=full_feature_names,
entity_rows=request.entities,
full_feature_names=request.full_feature_names,
)

if store._get_provider().async_supported.online.read:
Expand Down

0 comments on commit b7cedb7

Please sign in to comment.