Cache nonParameterCharacterSet in SOCKit.m to avoid memory spikes in …

…multithreaded environments Relevant github.com pull request into SOCKit is located here: NimbusKit#26
robinhoodmarkets · Jul 7, 2015 · 2cac171 · 2cac171
1 parent 90937fd
commit 2cac171
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/SOCKit.m b/src/SOCKit.m
@@ -71,10 +71,15 @@ - (id)copyWithZone:(NSZone *)zone {
 #pragma mark - Pattern Compilation
 
 - (NSCharacterSet *)nonParameterCharacterSet {
-  NSMutableCharacterSet* parameterCharacterSet = [NSMutableCharacterSet alphanumericCharacterSet];
-  [parameterCharacterSet addCharactersInString:@".@_"];
-  NSCharacterSet* nonParameterCharacterSet = [parameterCharacterSet invertedSet];
-  return nonParameterCharacterSet;
+  static NSCharacterSet* staticNonParameterCharacterSet = nil;
+  static dispatch_once_t onceToken;
+  dispatch_once(&onceToken, ^{
+    NSMutableCharacterSet* parameterCharacterSet = [NSMutableCharacterSet alphanumericCharacterSet];
+    [parameterCharacterSet addCharactersInString:@".@_"];
+    staticNonParameterCharacterSet = [parameterCharacterSet invertedSet];
+  });
+
+  return staticNonParameterCharacterSet;
 }
 
 - (void)_compilePattern {