raise PBKDF2 iterations in backward compatible way #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on #159 , this PR does the following:
I tested:
I'm not yet sure what will be the final iteration count, as the JS implementation is pretty slow and we don't want to impact decrypting users too much. 50k is definitely noticeable, around 1s on a decent CPU.
I think the order of magnitude is what matters: going from 1k to 10k is significant, going from 15k to 50k maybe not so much, so I'll test a little more.
Once that's done and merged in 2.x, another PR will update 1.x.
Legacy template:
![Screenshot from 2023-02-26 11-56-18](https://user-images.githubusercontent.com/5664025/221406335-bea4510e-8a83-412f-9fd2-4153a9ba59d8.png)
Short password:
![Screenshot from 2023-03-01 18-45-01](https://user-images.githubusercontent.com/5664025/222220118-76652b56-d9cf-4f24-ba11-88466a468098.png)