Fetch timeout polyfill #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,81 @@ | |||
| 'use strict'; | |||
|
|
|||
| // Polyfill from https://github.com/github/fetch/blob/v1.1.1/fetch.js#L8-L21 | |||
There was a problem hiding this comment.
Let's get some permanent links to all linked files.
While viewing the file in github, you can press y to transform the URL into a permanent form.
There was a problem hiding this comment.
This link is for a tag -- same idea
christophermark
suggested changes
Mar 17, 2017
christophermark
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
fetchto respect atimeoutvalue.See the README for a description of how this works and how it will be maintained.
TL;DR
Networking on the JS side is all done through a library called
fetch(specification).fetchis an abstraction on top of XMLHttpRequest, which is a browser API for networking.React Native implements the XMLHttpRequest API with a backing native networking module, RCTNetworking (interfaced by an ios and android JS file).
This supports all the bells and whistles for timeouts and aborting requests, the problem is that the the fetch specification doesn't describe a standard for aborting and timing out requests.
The polyfill allows the
timeoutto reach the underlyingXMLHttpRequestinstance.