New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor downloader #448

Merged

robinraju merged 2 commits into main from refactor-downloader

Jun 6, 2022

Owner

robinraju commented Jun 6, 2022

Changes

Refactor downloader for better unit testing capability
Add HTTP mocking using nock to unit tests
Use BearerCredentialHandler from typed-rest-client instead for manually setting Auth token headers on requests to GH API.
- This removes the workaround introduced to fix Getting 400 on all downloads #333

robinraju added 2 commits

June 6, 2022 13:46


          Refactor: Move downloader to a class

77f7ac0


          Use BearerCredentialHandler from typed-rest-client for authentication

Add http response mock to unit tests

robinraju merged commit e0d2238 into main

robinraju deleted the refactor-downloader branch

June 6, 2022 19:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet